JNSimba commented on code in PR #449:
URL:
https://github.com/apache/doris-flink-connector/pull/449#discussion_r1692777906
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/JsonDebeziumChangeContext.java:
##########
@@ -82,8 +84,9 @@ public String getTargetDatabase() {
return targetDatabase;
}
+ @Deprecated
public Map<String, String> getTableProperties() {
- return tableProperties;
+ return Objects.nonNull(dorisTableConfig) ?
dorisTableConfig.getTableProperties() : null;
Review Comment:
Will returning null cause problems for downstream users of this method, or
can you consider returning an empty map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
