xzj7019 commented on code in PR #38317: URL: https://github.com/apache/doris/pull/38317#discussion_r1692607220
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/InnerJoinLAsscomProject.java: ########## @@ -98,7 +98,7 @@ public Rule build() { newTopHashConjuncts.forEach(expr -> topUsedExprIds.addAll(expr.getInputSlotExprIds())); newTopOtherConjuncts.forEach(expr -> topUsedExprIds.addAll(expr.getInputSlotExprIds())); Plan left = CBOUtils.newProject(topUsedExprIds, newBottomJoin); Review Comment: why not apply this for both sides? Means left side's new project is a must? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org