github-actions[bot] commented on code in PR #38385:
URL: https://github.com/apache/doris/pull/38385#discussion_r1691308420
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -55,6 +55,15 @@ uint8_t mysql_week_mode(uint32_t mode) {
return mode;
}
+static bool check_space(char ch) {
+ // \t, \n, \v, \f, \r are 9~13, respectively.
+ return UNLIKELY(ch == ' ' || (ch >= 9 && ch <= 13));
Review Comment:
warning: boolean expression can be simplified by DeMorgan's theorem
[readability-simplify-boolean-expr]
```cpp
return UNLIKELY(ch == ' ' || (ch >= 9 && ch <= 13));
^
```
<details>
<summary>Additional context</summary>
**be/src/common/compiler_util.h:35:** expanded from macro 'UNLIKELY'
```cpp
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
^
```
</details>
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -1987,13 +1996,13 @@
bool convert_zero) {
return from_date_str_base(date_str, len, scale, nullptr, convert_zero);
}
-// when we parse
template <typename T>
bool DateV2Value<T>::from_date_str(const char* date_str, int len,
const cctz::time_zone& local_time_zone, int
scale /* = -1*/,
bool convert_zero) {
return from_date_str_base(date_str, len, scale, &local_time_zone,
convert_zero);
}
+// if local_time_zone is null, only be able to parse time without timezone
template <typename T>
bool DateV2Value<T>::from_date_str_base(const char* date_str, int len, int
scale,
Review Comment:
warning: function 'from_date_str_base' has cognitive complexity of 116
(threshold 50) [readability-function-cognitive-complexity]
```cpp
bool DateV2Value<T>::from_date_str_base(const char* date_str, int len, int
scale,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/runtime/vdatetime_value.cpp:2016:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end && check_space(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2016:** +1
```cpp
while (ptr < end && check_space(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2019:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (ptr == end || !isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2019:** +1
```cpp
if (ptr == end || !isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2024:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2024:** +1
```cpp
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2024:** +1
```cpp
while (pos < end && (isdigit(*pos) || *pos == 'T')) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2034:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (pos == end || *pos == '.' ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2034:** +1
```cpp
if (pos == end || *pos == '.' ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2036:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (digits == 4 || digits == 8 || digits >= 14) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2036:** +1
```cpp
if (digits == 4 || digits == 8 || digits >= 14) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2038:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2049:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
while (ptr < end && isdigit(*ptr) && field_idx < MAX_DATE_PARTS) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2049:** +1
```cpp
while (ptr < end && isdigit(*ptr) && field_idx < MAX_DATE_PARTS) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2052:** +1
```cpp
bool scan_to_delim = (!is_interval_format) && (field_idx != 6);
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2053:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--))
{ // field_len <= 7
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2053:** +1
```cpp
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--))
{ // field_len <= 7
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2053:** +1
```cpp
while (ptr < end && isdigit(*ptr) && (scan_to_delim || field_len--))
{ // field_len <= 7
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2058:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (ptr == start) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2062:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 6) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2063:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2068:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (scale >= 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2079:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (reminder >= 5 * normalizer) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2084:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
if (temp_val == int_exp10(7)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2087:** +1, nesting level increased
to 5
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2093:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
while (ptr < end && isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2093:** +1
```cpp
while (ptr < end && isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2096:** +1, nesting level increased
to 3
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2104:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (temp_val > 999999L) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2110:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 6) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2114:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2120:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (ptr == end) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2126:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (UNLIKELY((field_idx > 2 ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2128:** +1
```cpp
&& time_zone_begins(ptr, end))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2126:** +1
```cpp
if (UNLIKELY((field_idx > 2 ||
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2129:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (local_time_zone == nullptr) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2137:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 2 && *ptr == 'T') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2137:** +1
```cpp
if (field_idx == 2 && *ptr == 'T') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2145:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (field_idx == 5) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2146:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (*ptr == '.') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2151:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if constexpr (is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2153:** +1, nesting level increased
to 4
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2156:** +1, nesting level increased
to 3
```cpp
} else if (isdigit(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2164:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (ptr < end && (check_date_punct(*ptr) || check_space(*ptr))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2164:** +1
```cpp
while (ptr < end && (check_date_punct(*ptr) || check_space(*ptr))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2164:** +1
```cpp
while (ptr < end && (check_date_punct(*ptr) || check_space(*ptr))) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2165:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (check_space(*ptr)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2166:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (((1 << field_idx) & allow_space_mask) == 0) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2170:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (*ptr == '-') {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2179:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!is_interval_format) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2182:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
for (; field_idx < MAX_DATE_PARTS; ++field_idx) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2186:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (year_len == 2) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2187:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (date_val[0] < YY_PART_YEAR) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2189:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2194:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (num_field < 3) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2197:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (is_invalid(date_val[0], date_val[1], date_val[2], 0, 0, 0, 0)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2198:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (date_val[0] == 0 && date_val[1] == 0 && date_val[2] == 0 &&
convert_zero) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2198:** +1
```cpp
if (date_val[0] == 0 && date_val[1] == 0 && date_val[2] == 0 &&
convert_zero) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2201:** +1, nesting level increased
to 2
```cpp
} else {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2206:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (need_use_timezone) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2208:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (!TimezoneUtils::find_cctz_time_zone(std::string {ptr, end},
given_tz)) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2221:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if constexpr (!is_datetime) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2222:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (sec_offset) {
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2224:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!tmp.check_range_and_set_time(date_val[0], date_val[1],
date_val[2], date_val[3],
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2228:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (!tmp.date_add_interval<TimeUnit::SECOND>(
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2237:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (!check_range_and_set_time(date_val[0], date_val[1], date_val[2],
date_val[3], date_val[4],
^
```
**be/src/vec/runtime/vdatetime_value.cpp:2242:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
return sec_offset ? date_add_interval<TimeUnit::SECOND>(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
