DongLiang-0 commented on code in PR #446:
URL:
https://github.com/apache/doris-flink-connector/pull/446#discussion_r1691124920
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##########
@@ -347,16 +343,18 @@ public boolean doConvert(
String stringValue = new
String(varCharVector.get(rowIndex));
LocalDateTime parse = LocalDateTime.parse(stringValue,
dateTimeFormatter);
addValueToRow(rowIndex, parse);
- } else {
+ } else if (fieldVector instanceof TimeStampVector) {
LocalDateTime dateTime = getDateTime(rowIndex,
fieldVector);
addValueToRow(rowIndex, dateTime);
+ } else {
+ logger.error(
+ "Unsupported type for DATETIME, minorType {},
vector {}",
+ minorType.name(),
+ fieldVector);
Review Comment:
```suggestion
fieldVector.getClass().getName())
```
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/serialization/RowBatch.java:
##########
@@ -367,9 +365,15 @@ public boolean doConvert(
stringValue = completeMilliseconds(stringValue);
LocalDateTime parse = LocalDateTime.parse(stringValue,
dateTimeV2Formatter);
addValueToRow(rowIndex, parse);
- } else {
+ } else if (fieldVector instanceof TimeStampVector) {
LocalDateTime dateTime = getDateTime(rowIndex,
fieldVector);
addValueToRow(rowIndex, dateTime);
+ } else {
+ logger.error(
+ "Unsupported type for DATETIMEV2, minorType {},
vector {}",
+ minorType.name(),
+ fieldVector);
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
