This is an automated email from the ASF dual-hosted git repository.
lihaopeng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new c16ea419b27 [Bug](agg) fix collect_set function core dump without
arena pool (#38234)
c16ea419b27 is described below
commit c16ea419b27095a37d54005815f441512ef5b782
Author: zhangstar333 <87313068+zhangstar...@users.noreply.github.com>
AuthorDate: Wed Jul 24 16:18:07 2024 +0800
[Bug](agg) fix collect_set function core dump without arena pool (#38234)
before the add_range_single_place pass nullptr as arena object,
but collect_set function need save data in arena, so will core dump
without arena pool.
---
be/src/pipeline/exec/analytic_source_operator.cpp | 4 +---
.../data/nereids_function_p0/agg_function/group_unique_array.out | 9 +++++++++
.../nereids_function_p0/agg_function/group_unique_array.groovy | 3 +++
3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/be/src/pipeline/exec/analytic_source_operator.cpp
b/be/src/pipeline/exec/analytic_source_operator.cpp
index a036481d727..406108fbc4f 100644
--- a/be/src/pipeline/exec/analytic_source_operator.cpp
+++ b/be/src/pipeline/exec/analytic_source_operator.cpp
@@ -279,8 +279,6 @@ void AnalyticLocalState::_destroy_agg_status() {
}
}
-//now is execute for lead/lag row_number/rank/dense_rank/ntile functions
-//sum min max count avg first_value last_value functions
void AnalyticLocalState::_execute_for_win_func(int64_t partition_start,
int64_t partition_end,
int64_t frame_start, int64_t
frame_end) {
for (size_t i = 0; i < _agg_functions_size; ++i) {
@@ -292,7 +290,7 @@ void AnalyticLocalState::_execute_for_win_func(int64_t
partition_start, int64_t
partition_start, partition_end, frame_start, frame_end,
_fn_place_ptr +
_parent->cast<AnalyticSourceOperatorX>()._offsets_of_aggregate_states[i],
- agg_columns.data(), nullptr);
+ agg_columns.data(), _agg_arena_pool.get());
// If the end is not greater than the start, the current window should
be empty.
_current_window_empty =
diff --git
a/regression-test/data/nereids_function_p0/agg_function/group_unique_array.out
b/regression-test/data/nereids_function_p0/agg_function/group_unique_array.out
index 036ac5ce57f..74c053e38f6 100644
---
a/regression-test/data/nereids_function_p0/agg_function/group_unique_array.out
+++
b/regression-test/data/nereids_function_p0/agg_function/group_unique_array.out
@@ -8,3 +8,12 @@
3 ["2023-01-02"] ["hello"]
4 ["2023-01-02", "2023-01-03"] ["sql"]
+-- !3 --
+["doris", "world", "hello", "sql"]
+["doris", "world", "hello", "sql"]
+["doris", "world", "hello", "sql"]
+["doris", "world", "hello", "sql"]
+["doris", "world", "hello", "sql"]
+["doris", "world", "hello", "sql"]
+["doris", "world", "hello", "sql"]
+
diff --git
a/regression-test/suites/nereids_function_p0/agg_function/group_unique_array.groovy
b/regression-test/suites/nereids_function_p0/agg_function/group_unique_array.groovy
index f17eadf73a5..f110f1a50c9 100644
---
a/regression-test/suites/nereids_function_p0/agg_function/group_unique_array.groovy
+++
b/regression-test/suites/nereids_function_p0/agg_function/group_unique_array.groovy
@@ -48,4 +48,7 @@ suite("group_unique_array") {
qt_2 """
select k1,collect_set(k2),collect_set(k3,1) from
test_group_unique_array_table group by k1 order by k1;
"""
+ qt_3 """
+ select collect_set(k3) over() from test_group_unique_array_table;
+ """
}
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
