eldenmoon commented on code in PR #38236:
URL: https://github.com/apache/doris/pull/38236#discussion_r1689203039
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -258,8 +258,13 @@ Status SegmentWriter::_create_column_writer(uint32_t cid,
const TabletColumn& co
if (column.is_row_store_column()) {
// smaller page size for row store column
- opts.data_page_size = _tablet_schema->row_store_page_size();
+ auto page_size = _tablet_schema->row_store_page_size();
+ opts.data_page_size = (page_size > 0) ? page_size : ([this]() {
+
_tablet_schema->set_row_store_page_size(segment_v2::ROW_STORE_PAGE_SIZE_DEFAULT_VALUE);
+ return segment_v2::ROW_STORE_PAGE_SIZE_DEFAULT_VALUE;
Review Comment:
don't set use default directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
