github-actions[bot] commented on code in PR #38290:
URL: https://github.com/apache/doris/pull/38290#discussion_r1689192999
##########
be/src/service/internal_service.cpp:
##########
@@ -288,6 +288,9 @@ void
PInternalService::exec_plan_fragment(google::protobuf::RpcController* contr
const PExecPlanFragmentRequest*
request,
PExecPlanFragmentResult* response,
google::protobuf::Closure* done) {
+ timeval tv {};
+ gettimeofday(&tv, NULL);
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
gettimeofday(&tv, nullptr);
```
##########
be/src/service/internal_service.cpp:
##########
@@ -301,6 +304,9 @@
const
PExecPlanFragmentRequest* request,
PExecPlanFragmentResult*
response,
google::protobuf::Closure* done) {
+ timeval tv1 {};
+ gettimeofday(&tv1, NULL);
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
gettimeofday(&tv1, nullptr);
```
##########
be/src/service/internal_service.cpp:
##########
@@ -318,12 +324,18 @@
LOG(WARNING) << "exec plan fragment failed, errmsg=" << st;
}
st.to_protobuf(response->mutable_status());
+ timeval tv2 {};
+ gettimeofday(&tv2, NULL);
+ response->set_execution_done_time(tv2.tv_sec * 1000LL + tv2.tv_usec /
1000);
}
void
PInternalService::exec_plan_fragment_prepare(google::protobuf::RpcController*
controller,
const
PExecPlanFragmentRequest* request,
PExecPlanFragmentResult*
response,
google::protobuf::Closure*
done) {
+ timeval tv {};
+ gettimeofday(&tv, NULL);
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
gettimeofday(&tv, nullptr);
```
##########
be/src/service/internal_service.cpp:
##########
@@ -318,12 +324,18 @@
LOG(WARNING) << "exec plan fragment failed, errmsg=" << st;
}
st.to_protobuf(response->mutable_status());
+ timeval tv2 {};
+ gettimeofday(&tv2, NULL);
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
gettimeofday(&tv2, nullptr);
```
##########
be/src/service/internal_service.cpp:
##########
@@ -337,10 +349,19 @@
const
PExecPlanFragmentStartRequest* request,
PExecPlanFragmentResult*
result,
google::protobuf::Closure*
done) {
+ timeval tv {};
+ gettimeofday(&tv, NULL);
Review Comment:
warning: use nullptr [modernize-use-nullptr]
```suggestion
gettimeofday(&tv, nullptr);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
