eldenmoon commented on code in PR #38035: URL: https://github.com/apache/doris/pull/38035#discussion_r1689080262
########## be/src/olap/compaction.cpp: ########## @@ -400,16 +400,31 @@ Status CompactionMixin::execute_compact() { data_dir->disks_compaction_score_increment(permits); data_dir->disks_compaction_num_increment(1); - Status st = execute_compact_impl(permits); + try { + doris::enable_thread_catch_bad_alloc++; Review Comment: why not use RETURN_IF_ERROR_OR_CATCH_EXCEPTION? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org