github-actions[bot] commented on code in PR #37257: URL: https://github.com/apache/doris/pull/37257#discussion_r1688449891
########## be/src/vec/exec/format/parquet/arrow_memory_pool.cpp: ########## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vec/exec/format/parquet/arrow_memory_pool.h" + +#include "glog/logging.h" + +namespace doris::vectorized { + +// A static piece of memory for 0-size allocations, so as to return +// an aligned non-null pointer. Note the correct value for DebugAllocator +// checks is hardcoded. +alignas(kDefaultBufferAlignment) int64_t zero_size_area[1] = {kDebugXorSuffix}; + +arrow::Status ArrowAllocator::allocate_aligned(int64_t size, int64_t alignment, uint8_t** out) { + if (size == 0) { + *out = kZeroSizeArea; + return arrow::Status::OK(); + } + *out = reinterpret_cast<uint8_t*>(_allocator.alloc(size, alignment)); + if (*out == nullptr) { + return arrow::Status::OutOfMemory("malloc of size ", size, " failed"); + } + return arrow::Status::OK(); +} + +arrow::Status ArrowAllocator::reallocate_aligned(int64_t old_size, int64_t new_size, + int64_t alignment, uint8_t** ptr) { + uint8_t* previous_ptr = *ptr; + if (previous_ptr == kZeroSizeArea) { + DCHECK_EQ(old_size, 0); + return allocate_aligned(new_size, alignment, ptr); + } + if (new_size == 0) { + deallocate_aligned(previous_ptr, old_size, alignment); + *ptr = kZeroSizeArea; + return arrow::Status::OK(); + } + *ptr = reinterpret_cast<uint8_t*>(_allocator.realloc(*ptr, static_cast<size_t>(old_size), + static_cast<size_t>(new_size), alignment)); + if (*ptr == nullptr) { + *ptr = previous_ptr; + return arrow::Status::OutOfMemory("realloc of size ", new_size, " failed"); + } + return arrow::Status::OK(); +} + +void ArrowAllocator::deallocate_aligned(uint8_t* ptr, int64_t size, int64_t alignment) { Review Comment: warning: pointer parameter 'ptr' can be pointer to const [readability-non-const-parameter] ```suggestion void ArrowAllocator::deallocate_aligned(const uint8_t* ptr, int64_t size, int64_t alignment) { ``` be/src/vec/exec/format/parquet/arrow_memory_pool.h:47: ```diff - void deallocate_aligned(uint8_t* ptr, int64_t size, int64_t alignment); + void deallocate_aligned(const uint8_t* ptr, int64_t size, int64_t alignment); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
