924060929 commented on code in PR #38191:
URL: https://github.com/apache/doris/pull/38191#discussion_r1686162014
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java:
##########
@@ -1989,9 +1989,7 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- return Objects.hash(state, indexIdToMeta, indexNameToId, keysType,
partitionInfo, idToPartition,
Review Comment:
1. Why should we use selectedIndex as hashCode？equals function contains it,
so I think selectedIndex can be removed in hashCode function
2. use partition-related field to compute hash code is inefficient when the
table contains lots of partitions
other fields seems not very useful in the hashCode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
