yiguolei commented on code in PR #33690:
URL: https://github.com/apache/doris/pull/33690#discussion_r1685914910
##########
fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java:
##########
@@ -167,18 +167,9 @@ public void unregisterQuery(TUniqueId queryId) {
if (LOG.isDebugEnabled()) {
LOG.debug("Deregister query id {}",
DebugUtil.printId(queryId));
}
- ExecutionProfile executionProfile =
ProfileManager.getInstance().getExecutionProfile(queryId);
- if (executionProfile != null) {
-
executionProfile.setQueryFinishTime(System.currentTimeMillis());
- if (queryInfo.connectContext != null) {
- long autoProfileThresholdMs = queryInfo.connectContext
- .getSessionVariable().getAutoProfileThresholdMs();
- if (autoProfileThresholdMs > 0 &&
System.currentTimeMillis() - queryInfo.getStartExecTime()
- < autoProfileThresholdMs) {
-
ProfileManager.getInstance().removeProfile(executionProfile.getSummaryProfile().getProfileId());
- }
- }
- }
+
+ ProfileManager.getInstance().markQueryFinished(queryId);
Review Comment:
这里不对。
QeProcesssorImpl z只跟execution profile 关联，不能跟profile 关联。
比如，我们把execution profile register 了，然后query 异常退出，没有push profile，那么这就会有泄露。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
