yiguolei commented on a change in pull request #8452:
URL: https://github.com/apache/incubator-doris/pull/8452#discussion_r825663755
##########
File path: be/src/olap/tablet.h
##########
@@ -143,21 +143,9 @@ class Tablet : public BaseTablet {
// meta lock
inline std::shared_mutex& get_header_lock() { return _meta_lock; }
-
- // ingest lock
- inline void obtain_push_lock() { _ingest_lock.lock(); }
- inline void release_push_lock() { _ingest_lock.unlock(); }
- inline Mutex* get_push_lock() { return &_ingest_lock; }
-
- // base lock
- inline void obtain_base_compaction_lock() { _base_lock.lock(); }
- inline void release_base_compaction_lock() { _base_lock.unlock(); }
- inline Mutex* get_base_lock() { return &_base_lock; }
-
- // cumulative lock
- inline void obtain_cumulative_lock() { _cumulative_lock.lock(); }
- inline void release_cumulative_lock() { _cumulative_lock.unlock(); }
- inline Mutex* get_cumulative_lock() { return &_cumulative_lock; }
+ inline std::mutex& get_push_lock() { return _ingest_lock; }
+ inline std::mutex& get_base_lock() { return _base_lock; }
Review comment:
maybe get_base_compaction_lock better? and
get_cumulative_compaction_lock()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
