morrySnow commented on code in PR #37790:
URL: https://github.com/apache/doris/pull/37790#discussion_r1682503740
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalPlan.java:
##########
@@ -107,4 +108,8 @@ default DataTrait computeDataTrait() {
void computeEqualSet(DataTrait.Builder builder);
void computeFd(DataTrait.Builder builder);
+
+ default StmtType stmtType() {
+ return StmtType.OTHER;
Review Comment:
do not give default impl, let it be abstract
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/StmtType.java:
##########
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+public enum StmtType {
+ DDL,
Review Comment:
add comment
1. clarifying the criteria for classifying a statement. for example we have
DDL and CREATE, so when to use DDL directly, when to add a new type of DDL?
2. sort and classify these types for easy read and maintain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
