deardeng commented on code in PR #37787: URL: https://github.com/apache/doris/pull/37787#discussion_r1682138135
########## fe/fe-core/src/main/java/org/apache/doris/cloud/persist/UpdateCloudReplicaInfo.java: ########## @@ -54,6 +59,9 @@ public class UpdateCloudReplicaInfo implements Writable { @SerializedName(value = "beIds") private List<Long> beIds = new ArrayList<Long>(); + @SerializedName(value = "rids", alternate = {"replicaIds"}) Review Comment: fixed ########## fe/fe-core/src/main/java/org/apache/doris/persist/EditLog.java: ########## @@ -1264,6 +1266,25 @@ public void rollEditLog() { journal.rollJournal(); } + private synchronized <T extends Writable> void logEdit(short op, List<T> entries) throws IOException { + List<JournalBatch> batches = new ArrayList<>(); + JournalBatch batch = new JournalBatch(35); + for (T entry : entries) { + // the number of batch entities to less than 32 and the batch data size to less than 640KB + if (batch.getJournalEntities().size() >= 32 || batch.getSize() >= 640 * 1024) { + batches.add(batch); Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org