github-actions[bot] commented on code in PR #38035:
URL: https://github.com/apache/doris/pull/38035#discussion_r1681970586
##########
be/src/vec/columns/column_array.cpp:
##########
@@ -182,7 +189,8 @@ void ColumnArray::insert_data(const char* pos, size_t
length) {
/** Similarly - only for arrays of fixed length values.
*/
if (!data->is_fixed_and_contiguous())
- LOG(FATAL) << "Method insert_data is not supported for " << get_name();
+ throw doris::Exception(ErrorCode::INTERNAL_ERROR,
+ "Method insert_data is not supported for {}",
get_name());
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (pos != end) {
throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Incorrect
length argument for method ColumnArray::insert_data");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
