This is an automated email from the ASF dual-hosted git repository.

w41ter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new 721ecbcd943 [fix](fe) Fix `removeDroppedMember` use incorrect 
`nodeName` (#37987)
721ecbcd943 is described below

commit 721ecbcd943b760092ccf0ca1e62767f0e2b6a0f
Author: Lei Zhang <27994433+swjtu-zhang...@users.noreply.github.com>
AuthorDate: Wed Jul 17 19:17:32 2024 +0800

    [fix](fe) Fix `removeDroppedMember` use incorrect `nodeName` (#37987)
    
    ```
    com.sleepycat.je.rep.MasterStateException: (JE 18.3.12) Cannot remove an 
active master
        at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.checkMember(ReplicationGroupAdmin.java:591)
        at 
com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:315)
        at org.apache.doris.ha.BDBHA.removeDroppedMember(BDBHA.java:262)
        at org.apache.doris.catalog.Env.removeDroppedFrontends(Env.java:3077)
        at org.apache.doris.catalog.Env.transferToMaster(Env.java:1520)
        at org.apache.doris.catalog.Env.access$1300(Env.java:338)
        at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2792)
        at org.apache.doris.common.util.Daemon.run(Daemon.java:116)
    ```
    
    * the bug is introduced by https://github.com/apache/doris/pull/35203
---
 fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java 
b/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java
index d71ec29a9b7..5270bf19c54 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/ha/BDBHA.java
@@ -259,11 +259,11 @@ public class BDBHA implements HAProtocol {
             LOG.debug("node:{}", replicationNode.toString());
             if (removedFrontends.contains(replicationNode.getName())) {
                 try {
-                    replicationGroupAdmin.removeMember(nodeName);
+                    
replicationGroupAdmin.removeMember(replicationNode.getName());
                 } catch (MemberNotFoundException e) {
-                    LOG.warn("the electable node is not found {}", nodeName);
+                    LOG.warn("the electable node is not found {}", 
replicationNode.getName());
                 } catch (Exception e) {
-                    LOG.error("remove electable node {} meeting unknown 
exception:", nodeName, e);
+                    LOG.error("remove electable node {} meeting unknown 
exception:", replicationNode.getName(), e);
                     System.exit(-1);
                 }
             }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to