Gabriel39 commented on code in PR #37208:
URL: https://github.com/apache/doris/pull/37208#discussion_r1680480495
##########
be/src/vec/runtime/vdata_stream_recvr.cpp:
##########
@@ -63,18 +63,7 @@ VDataStreamRecvr::SenderQueue::~SenderQueue() {
}
Status VDataStreamRecvr::SenderQueue::get_batch(Block* block, bool* eos) {
- std::unique_lock<std::mutex> l(_lock);
- // wait until something shows up or we know we're done
- while (!_is_cancelled && _block_queue.empty() && _num_remaining_senders >
0) {
- VLOG_ROW << "wait arrival fragment_instance_id=" <<
print_id(_recvr->fragment_instance_id())
- << " node=" << _recvr->dest_node_id();
- // Don't count time spent waiting on the sender as active time.
- CANCEL_SAFE_SCOPED_TIMER(_recvr->_data_arrival_timer, &_is_cancelled);
- CANCEL_SAFE_SCOPED_TIMER(
- _received_first_batch ? nullptr :
_recvr->_first_batch_wait_total_timer,
- &_is_cancelled);
- _data_arrival_cv.wait(l);
- }
+ std::lock_guard<std::mutex> l(_lock);
return _inner_get_batch_without_lock(block, eos);
Review Comment:
`_inner_get_batch_without_lock` is not needed after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
