xiaokang commented on code in PR #37936:
URL: https://github.com/apache/doris/pull/37936#discussion_r1680273929
##########
be/src/util/mysql_row_buffer.cpp:
##########
@@ -44,6 +44,9 @@ namespace doris {
static uint8_t NEXT_TWO_BYTE = 252;
static uint8_t NEXT_THREE_BYTE = 253;
static uint8_t NEXT_EIGHT_BYTE = 254;
+// the EXTRA_RESERVE_BYTE wanner to make sure _pos pointer is always in _buf
memory
+// used in reserve() for allocate current buffer
+static size_t EXTRA_RESERVE_BYTE = 128;
Review Comment:
Why choose 128 bytes? Will it cause too much overhead for each row?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
