github-actions[bot] commented on PR #37887:
URL: https://github.com/apache/doris/pull/37887#issuecomment-2230115873
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/9951817212";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In tools/tpch-tools/bin/run-tpch-queries.sh line 81:
TPCH_QUERIES_DIR="${CURDIR}/../queries
^-- SC1078 (warning): Did you forget to close this double
quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 83:
echo "Running tpch sf 1 queries"
^-- SC1079 (info): This is actually an end quote, but due to next
char it looks suspect.
In tools/tpch-tools/bin/run-tpch-queries.sh line 136:
done < <(grep -v '^ *#' <"${TPCH_OPT_CONF}")
^-- SC1078 (warning): Did you
forget to close this double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 141:
echo "Optimize session variables"
^-- SC1079 (info): This is actually an end quote, but due to next char
it looks suspect.
In tools/tpch-tools/bin/run-tpch-queries.sh line 150:
if [[ -d "${RESULT_DIR}" ]]; then
^-- SC1078 (warning): Did you forget to close this
double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 151:
rm -r "${RESULT_DIR}"
^-- SC1079 (info): This is actually an end quote, but due to next
char it looks suspect.
In tools/tpch-tools/bin/run-tpch-queries.sh line 165:
echo -ne "q${i}\t" | tee -a result.csv
^-- SC1078 (warning): Did you forget to close this
double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 167:
mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out
2>"${RESULT_DIR}"/result"${i}".log
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this double
quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 170:
echo -ne "${cold}\t" | tee -a result.csv
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this
double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 173:
mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out
2>"${RESULT_DIR}"/result"${i}".log
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this double
quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 176:
echo -ne "${hot1}\t" | tee -a result.csv
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this
double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 179:
mysql -h"${FE_HOST}" -u "${USER}" -P"${FE_QUERY_PORT}" -D"${DB}"
--comments <"${TPCH_QUERIES_DIR}"/q"${i}".sql >"${RESULT_DIR}"/result"${i}".out
2>"${RESULT_DIR}"/result"${i}".log
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this double
quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 182:
echo -ne "${hot2}\t" | tee -a result.csv
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this
double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 187:
echo -ne "${hot1}" | tee -a result.csv
^-- SC1079 (info): This is actually an end quote, but due
to next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this
double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 188:
echo "" | tee -a result.csv
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this double
quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 191:
echo -ne "${hot2}" | tee -a result.csv
^-- SC1079 (info): This is actually an end quote, but due
to next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this
double quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 192:
echo "" | tee -a result.csv
^-- SC1079 (info): This is actually an end quote, but due to
next char it looks suspect.
^-- SC1078 (warning): Did you forget to close this double
quoted string?
In tools/tpch-tools/bin/run-tpch-queries.sh line 196:
echo "Total cold run time: ${cold_run_sum} ms"
^-- SC1079 (info): This is actually an end quote, but due to next char
it looks suspect.
In tools/tpch-tools/bin/run-tpch-queries.sh line 202:
run_sql "source ${backup_session_variables_file};"
^-- SC1009 (info): The
mentioned syntax error was in this simple command.
In tools/tpch-tools/bin/run-tpch-queries.sh line 203:
rm -f "${backup_session_variables_file}"
^-- SC1073 (error): Couldn't parse
this double quoted string. Fix to allow more checks.
In tools/tpch-tools/bin/run-tpch-queries.sh line 204:
^-- SC1072 (error): Expected end of double quoted string. Fix any mentioned
problems and try again.
For more information:
https://www.shellcheck.net/wiki/SC1078 -- Did you forget to close this
doub...
https://www.shellcheck.net/wiki/SC1079 -- This is actually an end quote,
bu...
https://www.shellcheck.net/wiki/SC1072 -- Expected end of double quoted
str...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
tools/tpch-tools/bin/run-tpch-queries.sh:203:40: reached EOF without closing
quote "
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
