This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new a78e67e9052 [fix](binlog) gc dropped partition records in disable 
binlog gc (#37326)
a78e67e9052 is described below

commit a78e67e9052602c32c21e6300e87783b5076777e
Author: walter <w41te...@gmail.com>
AuthorDate: Fri Jul 5 15:55:51 2024 +0800

    [fix](binlog) gc dropped partition records in disable binlog gc (#37326)
    
    This branch was missed in the PR #37196
---
 fe/fe-core/src/main/java/org/apache/doris/binlog/DBBinlog.java | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/binlog/DBBinlog.java 
b/fe/fe-core/src/main/java/org/apache/doris/binlog/DBBinlog.java
index 79e1adf20c9..bb9060c715a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/binlog/DBBinlog.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/binlog/DBBinlog.java
@@ -293,6 +293,7 @@ public class DBBinlog {
         return tombstone;
     }
 
+    // remove expired binlogs and dropped partitions, used in disable db 
binlog gc.
     private void removeExpiredMetaData(long largestExpiredCommitSeq) {
         lock.writeLock().lock();
         try {
@@ -321,6 +322,7 @@ public class DBBinlog {
                 }
             }
 
+            gcDroppedPartitions(largestExpiredCommitSeq);
             if (lastCommitSeq != -1) {
                 dummy.setCommitSeq(lastCommitSeq);
             }
@@ -331,6 +333,8 @@ public class DBBinlog {
         }
     }
 
+    // Get last expired binlog, and gc expired binlogs/timestamps/dropped
+    // partitions, used in enable db binlog gc.
     private TBinlog getLastExpiredBinlog(BinlogComparator checker) {
         TBinlog lastExpiredBinlog = null;
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to