This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push: new d728555f646 [fix](index) rollback in comopund index opt (#37742) d728555f646 is described below commit d728555f6468e41362dcc8c2a630ba769783ff85 Author: Kang <kxiao.ti...@gmail.com> AuthorDate: Sun Jul 14 00:10:43 2024 +0800 [fix](index) rollback in comopund index opt (#37742) ## Proposed changes rollback opt in #34134 --- be/src/olap/rowset/segment_v2/segment_iterator.cpp | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/be/src/olap/rowset/segment_v2/segment_iterator.cpp b/be/src/olap/rowset/segment_v2/segment_iterator.cpp index a8a9758afcd..a1cb81de2cc 100644 --- a/be/src/olap/rowset/segment_v2/segment_iterator.cpp +++ b/be/src/olap/rowset/segment_v2/segment_iterator.cpp @@ -814,16 +814,9 @@ Status SegmentIterator::_execute_predicates_except_leafnode_of_andnode( } else if (_is_literal_node(node_type)) { auto v_literal_expr = std::dynamic_pointer_cast<doris::vectorized::VLiteral>(expr); _column_predicate_info->query_values.insert(v_literal_expr->value()); - } else if (node_type == TExprNodeType::BINARY_PRED || node_type == TExprNodeType::MATCH_PRED || - node_type == TExprNodeType::IN_PRED) { + } else if (node_type == TExprNodeType::BINARY_PRED || node_type == TExprNodeType::MATCH_PRED) { if (node_type == TExprNodeType::MATCH_PRED) { _column_predicate_info->query_op = "match"; - } else if (node_type == TExprNodeType::IN_PRED) { - if (expr->op() == TExprOpcode::type::FILTER_IN) { - _column_predicate_info->query_op = "in"; - } else { - _column_predicate_info->query_op = "not_in"; - } } else { _column_predicate_info->query_op = expr->fn().name.function_name; } @@ -961,9 +954,7 @@ Status SegmentIterator::_apply_index_except_leafnode_of_andnode() { bool is_support = pred_type == PredicateType::EQ || pred_type == PredicateType::NE || pred_type == PredicateType::LT || pred_type == PredicateType::LE || pred_type == PredicateType::GT || pred_type == PredicateType::GE || - pred_type == PredicateType::MATCH || - pred_type == PredicateType::IN_LIST || - pred_type == PredicateType::NOT_IN_LIST; + pred_type == PredicateType::MATCH; if (!is_support) { _need_read_data_indices[column_id] = true; continue; @@ -1118,7 +1109,7 @@ Status SegmentIterator::_apply_inverted_index_on_column_predicate( } auto pred_type = pred->type(); - if (pred_type == PredicateType::MATCH || pred_type == PredicateType::IN_LIST) { + if (pred_type == PredicateType::MATCH) { std::string pred_result_sign = _gen_predicate_result_sign(pred); _rowid_result_for_index.emplace(pred_result_sign, std::make_pair(false, _row_bitmap)); } @@ -2813,12 +2804,6 @@ void SegmentIterator::_calculate_pred_in_remaining_conjunct_root( } else { if (node_type == TExprNodeType::MATCH_PRED) { _column_predicate_info->query_op = "match"; - } else if (node_type == TExprNodeType::IN_PRED) { - if (expr->op() == TExprOpcode::type::FILTER_IN) { - _column_predicate_info->query_op = "in"; - } else { - _column_predicate_info->query_op = "not_in"; - } } else if (node_type != TExprNodeType::COMPOUND_PRED) { _column_predicate_info->query_op = expr->fn().name.function_name; } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org