github-actions[bot] commented on code in PR #37630:
URL: https://github.com/apache/doris/pull/37630#discussion_r1675401621
##########
cloud/test/recycler_test.cpp:
##########
@@ -48,6 +48,8 @@ static const std::string instance_id =
"instance_id_recycle_test";
static int64_t current_time = 0;
static constexpr int64_t db_id = 1000;
+static std::unique_ptr<doris::cloud::RecyclerThreadPoolGroup> thread_group =
nullptr;
+
Review Comment:
warning: 'auto conf_file' can be declared as 'const auto *conf_file'
[readability-qualified-auto]
```suggestion
const auto *conf_file = "doris_cloud.conf";
```
##########
cloud/test/recycler_test.cpp:
##########
@@ -713,7 +716,7 @@
config::instance_recycler_worker_pool_size = 10;
config::recycle_task_threshold_seconds = 0;
- InstanceRecycler recycler(txn_kv, instance);
+ InstanceRecycler recycler(txn_kv, instance, *thread_group);
Review Comment:
warning: 'auto sp' can be declared as 'auto *sp' [readability-qualified-auto]
```suggestion
auto *sp = SyncPoint::get_instance();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
