github-actions[bot] commented on code in PR #37687:
URL: https://github.com/apache/doris/pull/37687#discussion_r1674228586
##########
be/src/vec/exec/format/file_reader/new_plain_text_line_reader.h:
##########
@@ -62,32 +61,47 @@ class BaseTextLineReaderContext : public
TextLineReaderContextIf {
public:
explicit BaseTextLineReaderContext(const std::string& line_delimiter_,
- const size_t line_delimiter_len_)
- : line_delimiter(line_delimiter_),
line_delimiter_len(line_delimiter_len_) {}
+ const size_t line_delimiter_len_, const
bool keep_cr_)
+ : line_delimiter(line_delimiter_),
+ line_delimiter_len(line_delimiter_len_),
+ keep_cr(keep_cr_) {
+ use_memmem = line_delimiter_len != 1 || line_delimiter != "\n" ||
keep_cr;
+ }
inline const uint8_t* read_line(const uint8_t* start, const size_t len)
final {
return static_cast<Ctx*>(this)->read_line_impl(start, len);
}
- [[nodiscard]] inline size_t line_delimiter_length() const final { return
line_delimiter_len; }
+ [[nodiscard]] inline size_t line_delimiter_length() const {
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
[[nodiscard]] inline size_t line_delimiter_length() const override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
