xiaokang commented on code in PR #37145:
URL: https://github.com/apache/doris/pull/37145#discussion_r1674051135


##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -95,6 +95,10 @@ public class PropertyAnalyzer {
     public static final String PROPERTIES_TIMEOUT = "timeout";
     public static final String PROPERTIES_COMPRESSION = "compression";
 
+    // row column page size, default 16KB
+    public static final String PROPERTIES_ROW_COLUMN_PAGE_SIZE = 
"row_column_page_size";

Review Comment:
   row_store_page_size



##########
cloud/cmake/thirdparty.cmake:
##########
@@ -59,7 +59,6 @@ add_thirdparty(protobuf)
 add_thirdparty(thrift)
 add_thirdparty(crypto)
 add_thirdparty(openssl LIBNAME "lib/libssl.a")
-add_thirdparty(jemalloc LIBNAME "lib/libjemalloc_doris.a")

Review Comment:
   why delete it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to