gavinchou commented on code in PR #37312: URL: https://github.com/apache/doris/pull/37312#discussion_r1665724594
########## be/src/io/cache/block_file_cache.h: ########## @@ -418,13 +420,15 @@ class BlockFileCache { LRUQueue _index_queue; LRUQueue _normal_queue; LRUQueue _disposable_queue; + LRUQueue _ttl_queue; // metrics size_t _num_read_blocks = 0; size_t _num_hit_blocks = 0; size_t _num_removed_blocks = 0; std::shared_ptr<bvar::Status<size_t>> _cur_cache_size_metrics; std::shared_ptr<bvar::Status<size_t>> _cur_ttl_cache_size_metrics; + std::shared_ptr<bvar::Status<size_t>> _cur_ttl_cache_lru_queue_size_metrics; Review Comment: is it "element count"? if no, add an "element count" bvar, if yes, keep the name consistency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org