github-actions[bot] commented on code in PR #37257:
URL: https://github.com/apache/doris/pull/37257#discussion_r1669884992
##########
be/src/vec/common/allocator.h:
##########
@@ -23,6 +23,7 @@
// TODO: Readable
#include <fmt/format.h>
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/format.h>
^
```
##########
be/src/vec/common/allocator.cpp:
##########
@@ -37,8 +40,9 @@
#include "util/stack_util.h"
#include "util/uid_util.h"
-template <bool clear_memory_, bool mmap_populate, bool use_mmap>
-void Allocator<clear_memory_, mmap_populate,
use_mmap>::sys_memory_check(size_t size) const {
+template <bool clear_memory_, bool mmap_populate, bool use_mmap, typename
MemoryAllocator>
+void Allocator<clear_memory_, mmap_populate, use_mmap,
MemoryAllocator>::sys_memory_check(
Review Comment:
warning: function 'sys_memory_check' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
void Allocator<clear_memory_, mmap_populate, use_mmap,
MemoryAllocator>::sys_memory_check(
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/common/allocator.cpp:43:** 112 lines including whitespace and
comments (threshold 80)
```cpp
void Allocator<clear_memory_, mmap_populate, use_mmap,
MemoryAllocator>::sys_memory_check(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
