xiaokang commented on code in PR #37428: URL: https://github.com/apache/doris/pull/37428#discussion_r1667930170
########## be/src/olap/rowset/segment_v2/segment_iterator.cpp: ########## @@ -2233,7 +2233,11 @@ Status SegmentIterator::_read_columns_by_rowids(std::vector<ColumnId>& read_colu } for (auto cid : read_column_ids) { - if (_prune_column(cid, (*mutable_columns)[cid], true, select_size)) { + auto& colunm = (*mutable_columns)[cid]; + if (_no_need_read_key_data(cid, colunm, select_size)) { Review Comment: can you call _no_need_read_key_data inside _prune_column? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org