gavinchou commented on code in PR #36786:
URL: https://github.com/apache/doris/pull/36786#discussion_r1666980466
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2143,15 +2165,21 @@ protected Partition createPartitionWithIndices(long
dbId, OlapTable tbl, long pa
return partition;
}
- protected void beforeCreatePartitions(long dbId, long tableId, List<Long>
partitionIds, List<Long> indexIds)
+ public void beforeCreatePartitions(long dbId, long tableId, List<Long>
partitionIds, List<Long> indexIds,
+ boolean isCreateTable)
throws DdlException {
}
- protected void afterCreatePartitions(long dbId, long tableId, List<Long>
partitionIds, List<Long> indexIds,
+ public void afterCreatePartitions(long dbId, long tableId, List<Long>
partitionIds, List<Long> indexIds,
boolean isCreateTable)
throws DdlException {
}
+ public void checkCreatePartitions(long dbId, long tableId, List<Long>
partitionIds, List<Long> indexIds)
Review Comment:
This function seems not necessary, the implementation can be done in
`CloudInternalCatalog.afterCreatePartitions()`
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -415,6 +416,18 @@ protected void afterCreatePartitions(long dbId, long
tableId, List<Long> partiti
}
}
+ public void checkCreatePartitions(long dbId, long tableId, List<Long>
partitionIds, List<Long> indexIds)
Review Comment:
This function seems not necessary, the implementation can be done in
`CloudInternalCatalog.afterCreatePartitions()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
