This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 749cab90b9f [feat](fe) Add a counter metric for recording large
editlog write (#37328)
749cab90b9f is described below
commit 749cab90b9f3c26ec661ff327d554d966c6ed13f
Author: Lei Zhang <27994433+swjtu-zhang...@users.noreply.github.com>
AuthorDate: Fri Jul 5 22:04:27 2024 +0800
[feat](fe) Add a counter metric for recording large editlog write (#37328)
---
.../main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java | 4 ++++
fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git
a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
index 1e54cc95a76..924f10b5ea1 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BDBJEJournal.java
@@ -244,6 +244,10 @@ public class BDBJEJournal implements Journal { //
CHECKSTYLE IGNORE THIS LINE: B
}
if (LOG.isDebugEnabled() || theData.getSize() > (1 << 20)) {
LOG.info("opCode = {}, journal size = {}", op, theData.getSize());
+ if (MetricRepo.isInit) {
+ MetricRepo.COUNTER_LARGE_EDIT_LOG.increase(1L);
+ }
+
}
// Write the key value pair to bdb.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java
b/fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java
index e16c3ef0cf7..70da86cae4f 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java
@@ -106,6 +106,8 @@ public final class MetricRepo {
public static LongCounterMetric COUNTER_CURRENT_EDIT_LOG_SIZE_BYTES;
public static LongCounterMetric COUNTER_EDIT_LOG_CLEAN_SUCCESS;
public static LongCounterMetric COUNTER_EDIT_LOG_CLEAN_FAILED;
+ public static LongCounterMetric COUNTER_LARGE_EDIT_LOG;
+
public static Histogram HISTO_EDIT_LOG_WRITE_LATENCY;
public static Histogram HISTO_JOURNAL_BATCH_SIZE;
public static Histogram HISTO_JOURNAL_BATCH_DATA_SIZE;
@@ -391,6 +393,12 @@ public final class MetricRepo {
"size of current edit log");
COUNTER_CURRENT_EDIT_LOG_SIZE_BYTES.addLabel(new MetricLabel("type",
"current_bytes"));
DORIS_METRIC_REGISTER.addMetrics(COUNTER_CURRENT_EDIT_LOG_SIZE_BYTES);
+
+ COUNTER_LARGE_EDIT_LOG = new LongCounterMetric("edit_log",
MetricUnit.OPERATIONS,
+ "counter of large edit log write into bdbje");
+ COUNTER_LARGE_EDIT_LOG.addLabel(new MetricLabel("type",
"large_write"));
+ DORIS_METRIC_REGISTER.addMetrics(COUNTER_LARGE_EDIT_LOG);
+
HISTO_EDIT_LOG_WRITE_LATENCY = METRIC_REGISTER.histogram(
MetricRegistry.name("editlog", "write", "latency", "ms"));
HISTO_JOURNAL_BATCH_SIZE = METRIC_REGISTER.histogram(
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
