gavinchou commented on code in PR #37291: URL: https://github.com/apache/doris/pull/37291#discussion_r1665342581
########## cloud/src/recycler/s3_accessor.cpp: ########## @@ -246,6 +247,9 @@ int S3Accessor::init() { Aws::Client::ClientConfiguration aws_config; aws_config.endpointOverride = conf_.endpoint; aws_config.region = conf_.region; + if (config::s3_client_http_scheme == "HTTP") { Review Comment: this is incorrect compared to the config.h validation. make it ignore case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org