github-actions[bot] commented on code in PR #33025:
URL: https://github.com/apache/doris/pull/33025#discussion_r1665078761
##########
be/src/olap/merger.cpp:
##########
@@ -336,25 +336,82 @@ Status Merger::vertical_compact_one_group(
}
// for segcompaction
-Status Merger::vertical_compact_one_group(int64_t tablet_id, ReaderType
reader_type,
- const TabletSchema& tablet_schema,
bool is_key,
- const std::vector<uint32_t>&
column_group,
- vectorized::RowSourcesBuffer*
row_source_buf,
- vectorized::VerticalBlockReader&
src_block_reader,
- segment_v2::SegmentWriter&
dst_segment_writer,
- int64_t max_rows_per_segment,
Statistics* stats_output,
- uint64_t* index_size, KeyBoundsPB&
key_bounds) {
+Status Merger::vertical_compact_one_group(
Review Comment:
warning: function 'vertical_compact_one_group' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status Merger::vertical_compact_one_group(
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/merger.cpp:338:** 106 lines including whitespace and comments
(threshold 80)
```cpp
Status Merger::vertical_compact_one_group(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
