seawinde commented on code in PR #36413:
URL: https://github.com/apache/doris/pull/36413#discussion_r1662617257
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java:
##########
@@ -40,28 +43,32 @@
import
org.apache.doris.nereids.trees.plans.visitor.TableCollector.TableCollectorContext;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.SessionVariable;
+import org.apache.doris.qe.VariableMgr;
import com.google.common.collect.Sets;
import java.util.List;
+import java.util.Map;
import java.util.Optional;
import java.util.Set;
public class MTMVPlanUtil {
- public static ConnectContext createMTMVContext(MTMV mtmv) {
+ public static ConnectContext createMTMVContext(MTMV mtmv) throws
DdlException {
ConnectContext ctx = new ConnectContext();
ctx.setEnv(Env.getCurrentEnv());
ctx.setQualifiedUser(Auth.ADMIN_USER);
ctx.setCurrentUserIdentity(UserIdentity.ADMIN);
ctx.getState().reset();
ctx.setThreadLocalInfo();
- ctx.getSessionVariable().enableFallbackToOriginalPlanner = false;
- ctx.getSessionVariable().enableNereidsDML = true;
- ctx.getSessionVariable().allowModifyMaterializedViewData = true;
+ SessionVariable sessionVariable = ctx.getSessionVariable();
+ setPersonalizedSession(sessionVariable, mtmv);
Review Comment:
if user set a sessions variable but is not exclusive by mtmv, what will
happen?
##########
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVPlanUtil.java:
##########
@@ -40,28 +43,32 @@
import
org.apache.doris.nereids.trees.plans.visitor.TableCollector.TableCollectorContext;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.qe.SessionVariable;
+import org.apache.doris.qe.VariableMgr;
import com.google.common.collect.Sets;
import java.util.List;
+import java.util.Map;
import java.util.Optional;
import java.util.Set;
public class MTMVPlanUtil {
- public static ConnectContext createMTMVContext(MTMV mtmv) {
+ public static ConnectContext createMTMVContext(MTMV mtmv) throws
DdlException {
ConnectContext ctx = new ConnectContext();
ctx.setEnv(Env.getCurrentEnv());
ctx.setQualifiedUser(Auth.ADMIN_USER);
ctx.setCurrentUserIdentity(UserIdentity.ADMIN);
ctx.getState().reset();
ctx.setThreadLocalInfo();
- ctx.getSessionVariable().enableFallbackToOriginalPlanner = false;
- ctx.getSessionVariable().enableNereidsDML = true;
- ctx.getSessionVariable().allowModifyMaterializedViewData = true;
+ SessionVariable sessionVariable = ctx.getSessionVariable();
+ setPersonalizedSession(sessionVariable, mtmv);
Review Comment:
if user set a session variable but is not exclusive by mtmv, what will
happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
