(doris) 15/44: [fix](cloud) Allow access to MS during the replay (#37053)

[dataroaring]

This is an automated email from the ASF dual-hosted git repository.

dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git

commit d29764be14cc3c0411a695c2cc2e3f6d2c635c8d
Author: walter <w41te...@gmail.com>
AuthorDate: Mon Jul 1 14:08:01 2024 +0800

    [fix](cloud) Allow access to MS during the replay (#37053)
    
    In some metadata designs, the process involves writing to the edit log
    first and then calling RPC to delete the data. The latter might fail, so
    it is reasonable to continue calling RPC to delete the data during
    replay. PR #36856 argues that not calling RPC in the checkpoint thread
    is problematic.
---
 .../main/java/org/apache/doris/alter/CloudSchemaChangeJobV2.java    | 4 ----
 .../src/main/java/org/apache/doris/cloud/rpc/MetaServiceProxy.java  | 6 ------
 2 files changed, 10 deletions(-)

diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/alter/CloudSchemaChangeJobV2.java 
b/fe/fe-core/src/main/java/org/apache/doris/alter/CloudSchemaChangeJobV2.java
index 373e644ec9e..2fe3d748602 100644
--- 
a/fe/fe-core/src/main/java/org/apache/doris/alter/CloudSchemaChangeJobV2.java
+++ 
b/fe/fe-core/src/main/java/org/apache/doris/alter/CloudSchemaChangeJobV2.java
@@ -112,10 +112,6 @@ public class CloudSchemaChangeJobV2 extends 
SchemaChangeJobV2 {
             return;
         }
 
-        if (Env.isCheckpointThread()) {
-            return;
-        }
-
         List<Long> shadowIdxList = 
indexIdMap.keySet().stream().collect(Collectors.toList());
         dropIndex(shadowIdxList);
     }
diff --git 
a/fe/fe-core/src/main/java/org/apache/doris/cloud/rpc/MetaServiceProxy.java 
b/fe/fe-core/src/main/java/org/apache/doris/cloud/rpc/MetaServiceProxy.java
index b321b6cffc5..00f271099e4 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/cloud/rpc/MetaServiceProxy.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/cloud/rpc/MetaServiceProxy.java
@@ -17,7 +17,6 @@
 
 package org.apache.doris.cloud.rpc;
 
-import org.apache.doris.catalog.Env;
 import org.apache.doris.cloud.proto.Cloud;
 import org.apache.doris.common.Config;
 import org.apache.doris.rpc.RpcException;
@@ -101,11 +100,6 @@ public class MetaServiceProxy {
     }
 
     private MetaServiceClient getProxy() {
-        if (Env.isCheckpointThread()) {
-            LOG.error("You should not use RPC in the checkpoint thread");
-            throw new RuntimeException("use RPC in the checkpoint thread");
-        }
-
         if (Config.enable_check_compatibility_mode) {
             LOG.error("Should not use RPC in check compatibility mode");
             throw new RuntimeException("use RPC in the check compatibility 
mode");


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org