This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 9f80a4b68f5 [Compatibility](agg-state) do not throw eception when
DataTypeAggState meet old be exec version (#37104)
9f80a4b68f5 is described below
commit 9f80a4b68f540fb65286c683b21ae5f6a826cdd8
Author: Pxl <pxl...@qq.com>
AuthorDate: Tue Jul 2 14:58:25 2024 +0800
[Compatibility](agg-state) do not throw eception when DataTypeAggState meet
old be exec version (#37104)
## Proposed changes
do not throw eception when DataTypeAggState meet old be exec version
this change is used to avoid memtable meet eception and core dump
---
be/src/vec/data_types/data_type_agg_state.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/be/src/vec/data_types/data_type_agg_state.h
b/be/src/vec/data_types/data_type_agg_state.h
index 6b4fdc64562..96b147c8e96 100644
--- a/be/src/vec/data_types/data_type_agg_state.h
+++ b/be/src/vec/data_types/data_type_agg_state.h
@@ -43,11 +43,13 @@ public:
_be_exec_version(be_exec_version) {
_agg_function =
AggregateFunctionSimpleFactory::instance().get(_function_name, _sub_types,
_result_is_nullable);
- if (_agg_function == nullptr ||
- !BeExecVersionManager::check_be_exec_version(be_exec_version)) {
+ if (_agg_function == nullptr) {
throw Exception(ErrorCode::INVALID_ARGUMENT,
"DataTypeAggState function get failed, type={}",
do_get_name());
}
+ if (!BeExecVersionManager::check_be_exec_version(be_exec_version)) {
+ LOG(WARNING) << "meet old agg-state, be_exec_version=" <<
be_exec_version;
+ }
_agg_function->set_version(be_exec_version);
_agg_serialized_type = _agg_function->get_serialized_type();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
