gavinchou commented on code in PR #36711:
URL: https://github.com/apache/doris/pull/36711#discussion_r1650018402
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java:
##########
@@ -517,6 +522,25 @@ public void analyze(Analyzer analyzer) throws
UserException {
user = ConnectContext.get().getQualifiedUser();
}
+
+ private String getProviderFromEndpoint(String endpoint) {
+ for (String provider : PROVIDERS) {
+ if (endpoint.toLowerCase().contains(provider.toLowerCase())) {
+ return provider;
+ }
+ }
+ return "s3";
+ }
+
+ private String getBucketFromFilePath(String filePath) throws Exception {
Review Comment:
too tricky to under stand... can we just pass the `bucket` properties of
S3LoadStmt to here?
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/LoadStmt.java:
##########
@@ -517,6 +522,25 @@ public void analyze(Analyzer analyzer) throws
UserException {
user = ConnectContext.get().getQualifiedUser();
}
+
+ private String getProviderFromEndpoint(String endpoint) {
Review Comment:
This is tricky...
We may known the exact provider after merging this PR
https://github.dev/apache/doris/pull/35990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
