JNSimba commented on code in PR #403: URL: https://github.com/apache/doris-flink-connector/pull/403#discussion_r1642580514
########## flink-doris-connector/src/main/java/org/apache/doris/flink/cfg/DorisOptions.java: ########## @@ -50,9 +51,11 @@ public DorisOptions( String password, String tableIdentifier, String jdbcUrl, - boolean redirect) { + boolean redirect, + String charsetEncoding) { Review Comment: Doris only supports UTF-8 encoding, so the DorisOption should not use this property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org