eldenmoon commented on code in PR #36275:
URL: https://github.com/apache/doris/pull/36275#discussion_r1642127374
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1815,19 +1811,23 @@ bool SegmentIterator::_has_char_type(const Field&
column_desc) {
}
};
-void SegmentIterator::_vec_init_char_column_id() {
+void SegmentIterator::_vec_init_char_column_id(vectorized::Block* block) {
for (size_t i = 0; i < _schema->num_column_ids(); i++) {
auto cid = _schema->column_id(i);
const Field* column_desc = _schema->column(cid);
- if (_has_char_type(*column_desc)) {
- _char_type_idx.emplace_back(i);
- if (i != 0) {
- _char_type_idx_no_0.emplace_back(i);
+ // The additional deleted filter condition will be in the materialized
column at the end of the block.
+ // After _output_column_by_sel_idx, it will be erased, so we do not
need to shrink it.
+ if (i < block->columns()) {
Review Comment:
why add this if branch? _has_char_type for delete predicate column should
always be false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
