csun5285 commented on code in PR #36163:
URL: https://github.com/apache/doris/pull/36163#discussion_r1641628342


##########
be/src/vec/common/schema_util.cpp:
##########
@@ -389,7 +389,7 @@ void inherit_column_attributes(const TabletColumn& source, 
TabletColumn& target,
         // add index meta
         TabletIndex index_info = *source_index_meta;
         
index_info.set_escaped_escaped_index_suffix_path(target.path_info_ptr()->get_path());
-        const auto* target_index_meta = 
target_schema->get_inverted_index(target);
+        const auto* target_index_meta = 
target_schema->get_inverted_index(target, false);

Review Comment:
   > Why not always check it?
   
   1. When the variant column is created, it has a TabletIndex. The extracted 
column from the variant will inherit this TabletIndex.
   2. The variant column itself is JSONB and does not support index,  no need 
to check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to