zzzxl1993 commented on code in PR #36292:
URL: https://github.com/apache/doris/pull/36292#discussion_r1641606526


##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -343,6 +343,34 @@ Status SegmentIterator::_init_impl(const 
StorageReadOptions& opts) {
             _storage_name_and_type[i] = std::make_pair(col->name(), 
storage_type);
         }
     }
+
+    // find columns that definitely require reading data, such as functions 
that are not pushed down.
+    {
+        std::set<std::string> push_down_preds;
+        for (auto* pred : _col_predicates) {
+            if (!_check_apply_by_inverted_index(pred)) {
+                continue;
+            }
+            push_down_preds.insert(_gen_predicate_result_sign(pred));

Review Comment:
   This section only calculates which conditions definitely require data 
reading, the conditions that do not require data reading are computed in other 
logical calculations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to