github-actions[bot] commented on code in PR #36322: URL: https://github.com/apache/doris/pull/36322#discussion_r1640788097
########## be/src/exec/olap_common.h: ########## @@ -802,16 +805,92 @@ bool ColumnValueRange<primitive_type>::convert_to_avg_range_value( } template <PrimitiveType primitive_type> -void ColumnValueRange<primitive_type>::convert_to_range_value() { - if (!is_range_value_convertible()) { +void ColumnValueRange<primitive_type>::convert_to_range_value( Review Comment: warning: function 'convert_to_range_value' exceeds recommended size/complexity thresholds [readability-function-size] ```cpp void ColumnValueRange<primitive_type>::convert_to_range_value( ^ ``` <details> <summary>Additional context</summary> **be/src/exec/olap_common.h:807:** 86 lines including whitespace and comments (threshold 80) ```cpp void ColumnValueRange<primitive_type>::convert_to_range_value( ^ ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org