Re: [PR] [fix](memory) Fix reserve memory compatible with memory GC and logging [doris]

[via GitHub]

HappenLee commented on code in PR #36307:
URL: https://github.com/apache/doris/pull/36307#discussion_r1640779379


##########
be/src/olap/memtable_memory_limiter.cpp:
##########
@@ -225,10 +225,8 @@ void MemTableMemoryLimiter::refresh_mem_tracker() {
     _log_timer.reset();
     // if not exist load task, this log should not be printed.
     if (_mem_usage != 0) {
-        LOG(INFO) << ss.str() << ", process mem: " << 
PerfCounters::get_vm_rss_str()
-                  << " (without allocator cache: "
-                  << 
PrettyPrinter::print_bytes(GlobalMemoryArbitrator::process_memory_usage())
-                  << "), load mem: " << 
PrettyPrinter::print_bytes(_mem_tracker->consumption())
+        LOG(INFO) << ss.str() << ", " << 
GlobalMemoryArbitrator::process_memory_used_details_str()

Review Comment:
   better do not use streamstring，use fmt to same work. the stringstream bad 
performance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org