github-actions[bot] commented on code in PR #36291:
URL: https://github.com/apache/doris/pull/36291#discussion_r1639155369
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -616,6 +619,16 @@ Status LoadBlockQueue::close_wal() {
return Status::OK();
}
+void LoadBlockQueue::append_dependency(std::shared_ptr<pipeline::Dependency>
finish_dep) {
Review Comment:
warning: method 'append_dependency' can be made const
[readability-make-member-function-const]
```suggestion
void LoadBlockQueue::append_dependency(std::shared_ptr<pipeline::Dependency>
finish_dep) const {
```
be/src/runtime/group_commit_mgr.h:85:
```diff
- void append_dependency(std::shared_ptr<pipeline::Dependency>
finish_dep);
+ void append_dependency(std::shared_ptr<pipeline::Dependency>
finish_dep) const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
