github-actions[bot] commented on code in PR #36283:
URL: https://github.com/apache/doris/pull/36283#discussion_r1638488693
##########
be/test/vec/function/function_string_test.cpp:
##########
@@ -2670,6 +2670,288 @@ TEST(function_string_test, function_replace) {
check_function_all_arg_comb<DataTypeString, true>(func_name, input_types,
data_set);
}
+TEST(function_string_test, function_replace_empty) {
+ std::string func_name = "replace_empty";
+ BaseInputTypeSet input_types = {
+ TypeIndex::String,
+ TypeIndex::String,
+ TypeIndex::String,
+ };
+ DataSet data_set = {
+ {{std::string("A"), std::string("A"), std::string("A")},
std::string("A")},
+ {{std::string("A"), std::string("A"), std::string(",")},
std::string(",")},
+ {{std::string("A"), std::string("A"), std::string("")},
std::string("")},
+ {{std::string("A"), std::string("A"), Null()}, Null()},
+ {{std::string("A"), std::string("A"), std::string(",ABC,")},
std::string(",ABC,")},
+ {{std::string("A"), std::string("A"), std::string("123ABC!@# _")},
+ std::string("123ABC!@# _")},
+ {{std::string("A"), std::string(","), std::string("A")},
std::string("A")},
+ {{std::string("A"), std::string(","), std::string(",")},
std::string("A")},
+ {{std::string("A"), std::string(","), std::string("")},
std::string("A")},
+ {{std::string("A"), std::string(","), Null()}, Null()},
+ {{std::string("A"), std::string(","), std::string(",ABC,")},
std::string("A")},
+ {{std::string("A"), std::string(","), std::string("123ABC!@# _")},
std::string("A")},
+ {{std::string("A"), std::string(""), std::string("A")},
std::string("AAA")},
+ {{std::string("A"), std::string(""), std::string(",")},
std::string(",A,")},
+ {{std::string("A"), std::string(""), std::string("")},
std::string("A")},
+ {{std::string("A"), std::string(""), Null()}, Null()},
+ {{std::string("A"), std::string(""), std::string(",ABC,")},
std::string(",ABC,A,ABC,")},
+ {{std::string("A"), std::string(""), std::string("123ABC!@# _")},
+ std::string("123ABC!@# _A123ABC!@# _")},
+ {{std::string("A"), Null(), std::string("A")}, Null()},
+ {{std::string("A"), Null(), std::string(",")}, Null()},
+ {{std::string("A"), Null(), std::string("")}, Null()},
+ {{std::string("A"), Null(), Null()}, Null()},
+ {{std::string("A"), Null(), std::string(",ABC,")}, Null()},
+ {{std::string("A"), Null(), std::string("123ABC!@# _")}, Null()},
+ {{std::string("A"), std::string(",ABC,"), std::string("A")},
std::string("A")},
+ {{std::string("A"), std::string(",ABC,"), std::string(",")},
std::string("A")},
Review Comment:
warning: function 'TEST' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
_name, input_types, data_set);
^
```
<details>
<summary>Additional context</summary>
**be/test/vec/function/function_string_test.cpp:2707:** 280 lines including
whitespace and comments (threshold 80)
```cpp
_name, input_types, data_set);
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
