github-actions[bot] commented on code in PR #36237:
URL: https://github.com/apache/doris/pull/36237#discussion_r1638251991
##########
be/src/runtime/stream_load/stream_load_context.cpp:
##########
@@ -350,4 +350,11 @@ std::string StreamLoadContext::brief(bool detail) const {
return ss.str();
}
+bool StreamLoadContext::is_mow_table() const {
+ return (put_result.__isset.params &&
put_result.params.__isset.is_mow_table &&
+ put_result.params.is_mow_table) ||
+ (put_result.__isset.pipeline_params &&
put_result.pipeline_params.__isset.is_mow_table &&
+ put_result.pipeline_params.is_mow_table);
+}
Review Comment:
warning: redundant boolean literal in conditional return statement
[readability-simplify-boolean-expr]
be/src/runtime/stream_load/stream_load_context.cpp:353:
```diff
- if ((put_result.__isset.params &&
put_result.params.__isset.is_mow_table &&
- put_result.params.is_mow_table) ||
- (put_result.__isset.pipeline_params &&
put_result.pipeline_params.__isset.is_mow_table &&
- put_result.pipeline_params.is_mow_table)) {
- return true;
- }
- return false;
+ return (put_result.__isset.params &&
put_result.params.__isset.is_mow_table &&
+ put_result.params.is_mow_table) ||
+ (put_result.__isset.pipeline_params &&
put_result.pipeline_params.__isset.is_mow_table &&
+ put_result.pipeline_params.is_mow_table);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
