iszhangpch commented on code in PR #36125:
URL: https://github.com/apache/doris/pull/36125#discussion_r1637436197


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionKey.java:
##########
@@ -59,9 +60,13 @@
 
 public class PartitionKey implements Comparable<PartitionKey>, Writable {
     private static final Logger LOG = LogManager.getLogger(PartitionKey.class);
+    @SerializedName("ks")
     private List<LiteralExpr> keys;

Review Comment:
   Hello, if the base class of "LiteralExpr", "Expr", has already registered a 
RuntimeTypeAdaptor containing "LiteralExpr"'s subtypes, should I register 
another RuntimeTypeAdaptor to avoid the deserialization failure? Because I 
noticed that a subtype registered to two different RuntimeTypeAdaptors will 
cause UT error "com.google.gson.JsonParseException: cannot serialize 
org.apache.doris.analysis.IntLiteral because it already defines a field named 
clazz"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to