amorynan commented on code in PR #36208:
URL: https://github.com/apache/doris/pull/36208#discussion_r1637274132


##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -385,13 +385,6 @@ class InvertedIndexColumnWriterImpl : public 
InvertedIndexColumnWriter {
                     if (null_map[j] == 1) {
                         continue;
                     }
-                    // now we temp create field . later make a pool
-                    if (Status st = create_field(&new_field); st != 
Status::OK()) {

Review Comment:
   here to create field would make field memory leak?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to