yujun777 commented on code in PR #35970:
URL: https://github.com/apache/doris/pull/35970#discussion_r1636241081
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1470,6 +1468,67 @@ private void checkReplicaContinuousVersionSucc(long
tabletId, Replica replica, b
}
}
+ private void checkReplicaContinuousVersionSucc(long tabletId, Replica
replica, boolean alterReplicaLoadedTxn,
Review Comment:
add argument: long alterWaterschedTxnId, List<Long> subTxnIds.
alterWaterschedTxnId: Max {job waterschedTxnId for job in
unfinishedAlterJobs and job's waterschedTxnId }, see function
isAlterReplicaLoadedTxn()
subTxnIds: should be the same with replicaPublishTasks
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java:
##########
@@ -1470,6 +1468,67 @@ private void checkReplicaContinuousVersionSucc(long
tabletId, Replica replica, b
}
}
+ private void checkReplicaContinuousVersionSucc(long tabletId, Replica
replica, boolean alterReplicaLoadedTxn,
Review Comment:
add argument: long alterWaterschedTxnId, List<Long> subTxnIds.
alterWaterschedTxnId: Max {job waterschedTxnId for job in
unfinishedAlterJobs and job's waterschedTxnId }, see function
isAlterReplicaLoadedTxn()
subTxnIds: should be the same with replicaPublishTasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
