github-actions[bot] commented on code in PR #36098:
URL: https://github.com/apache/doris/pull/36098#discussion_r1634123701
##########
be/src/runtime/load_channel.cpp:
##########
@@ -33,11 +33,11 @@ namespace doris {
bvar::Adder<int64_t> g_loadchannel_cnt("loadchannel_cnt");
LoadChannel::LoadChannel(const UniqueId& load_id, int64_t timeout_s, bool
is_high_priority,
- std::string sender_ip, int64_t backend_id, bool
enable_profile)
+ const std::string& sender_ip, int64_t backend_id,
bool enable_profile)
Review Comment:
warning: pass by value and use std::move [modernize-pass-by-value]
be/src/runtime/load_channel.cpp:21:
```diff
+
+ #include <utility>
```
```suggestion
std::string sender_ip, int64_t backend_id, bool
enable_profile)
```
be/src/runtime/load_channel.cpp:39:
```diff
- _sender_ip(sender_ip),
+ _sender_ip(std::move(sender_ip)),
```
be/src/runtime/load_channel.h:54:
```diff
- const std::string& sender_ip, int64_t backend_id, bool
enable_profile);
+ std::string sender_ip, int64_t backend_id, bool
enable_profile);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
