JNSimba commented on a change in pull request #4:
URL:
https://github.com/apache/incubator-doris-flink-connector/pull/4#discussion_r809699541
##########
File path:
flink-doris-connector/src/main/java/org/apache/doris/flink/table/DorisDynamicTableSink.java
##########
@@ -65,7 +66,7 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
.setExecutionOptions(executionOptions)
.setFieldDataTypes(tableSchema.getFieldDataTypes())
.setFieldNames(tableSchema.getFieldNames());
- return OutputFormatProvider.of(builder.build());
+ return new GenericDorisSinkFunction(builder.build());
Review comment:
Hello, I tested it locally. It seems that the **type conversion** of
`GenericDorisSinkFunction` to `SinkRuntimeProvider` will report an error. I
think it may be better to use `SinkFunctionProvider.of(new
GenericDorisSinkFunction(builder.build()))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
