Gabriel39 commented on code in PR #36071:
URL: https://github.com/apache/doris/pull/36071#discussion_r1634039248
##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -302,7 +302,7 @@ Status PipelineTask::execute(bool* eos) {
}
// The status must be runnable
if (!_opened && !_fragment_context->is_canceled()) {
- RETURN_IF_ERROR(_open());
Review Comment:
Exception is already caught by caller
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -337,13 +337,13 @@ Status PipelineFragmentContext::prepare(const
doris::TPipelineFragmentParams& re
for (PipelinePtr& pipeline : _pipelines) {
SCOPED_TIMER(_prepare_all_pipelines_timer);
pipeline->children().clear();
- RETURN_IF_ERROR(pipeline->prepare(_runtime_state.get()));
+
RETURN_IF_ERROR_OR_CATCH_EXCEPTION(pipeline->prepare(_runtime_state.get()));
Review Comment:
Maybe we should catch exception by `prepare`'s caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
